Make the class CommunityIdProcessor final #14448
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
gaobinlong
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14448 +/- ##
============================================
+ Coverage 71.42% 71.64% +0.22%
- Complexity 59978 62074 +2096
============================================
Files 4985 5118 +133
Lines 282275 291878 +9603
Branches 40946 42189 +1243
============================================
+ Hits 201603 209109 +7506
- Misses 63999 65511 +1512
- Partials 16673 17258 +585 ☔ View full report in Codecov by Sentry. |
|
❌ Gradle check result for b3c41e8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b023f72: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b023f72: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
approved these changes
Jun 19, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14448-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8aed62e4c56914be1ddc802a118e7fa6039d9dc1
# Push it to GitHub
git push --set-upstream origin backport/backport-14448-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
|
@gaobinlong could you please backport to |
gaobinlong
added a commit
to gaobinlong/OpenSearch
that referenced
this pull request
Jun 19, 2024
* Make the class CommunityIdProcessor final Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Update change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit 8aed62e)
gaobinlong
added a commit
to gaobinlong/OpenSearch
that referenced
this pull request
Jun 19, 2024
* Make the class CommunityIdProcessor final Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Update change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
3 tasks
reta
added a commit
that referenced
this pull request
Jun 19, 2024
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
* Make the class CommunityIdProcessor final Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Update change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…pensearch-project#14453) * Make the class CommunityIdProcessor final * Update change log --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
* Make the class CommunityIdProcessor final Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Update change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR for Add community_id ingest processor, the new added class CommunityIdProcessor should be final, but in the original PR we neglected that.
Other main classes of the ingest processors don't have this issue.
This PR should be backported to 2.x branch.
Related Issues
#2787
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.